search

uniqush / uniqush-push

Uniqush is a free and open source software system which provides a unified push service for server side notification to apps on mobile devices.
http://uniqush.org
Apache License 2.0
1.54k stars 201 forks source link

APNS Add psp "addr" setting bug #249

Closed sid-dob closed 4 years ago

sid-dob commented 4 years ago

There is a bug in the code because of which if you set sandbox=false it does not set the address as it is supposed to. Below is the link to the line :

https://github.com/uniqush/uniqush-push/blob/b5ab88a392399d859aff4d18a57689f30df14fa3/srv/apns/push_service.go#L141

I would have fixed and sent a PR, unfortunately I have 0 experience in go.

Thanks

sid-dob commented 4 years ago

Is there a release panned for the same ?

TysonAndre commented 4 years ago

Once I've verified that everything else in 2.7.0-dev has no issues on production use cases. This should be out by the end of the month.