Avoiding evals ?

[fabienjuif]

See : https://github.com/alakarteio/k-ramel/pull/127#discussion_r175028357

• [x] benchmark reduce solution over eval
• [x] find how lodash is doing that

[fabienjuif]

lodash:

• They loop over path : https://github.com/lodash/lodash/blob/master/.internal/baseGet.js#L15
• And before doing so, they cut the path string into an array : https://github.com/lodash/lodash/blob/master/.internal/stringToPath.js
• To get key of object at a time, they transform it to string : https://github.com/lodash/lodash/blob/master/.internal/toKey.js

So I guess this is OK to loop over path as you suggested @bpetetot

Something like you wrote:

const reducerPath = path.split('.')
const reducerName = reducerPath.pop()
const reducerLocation = reducerPath.reduce((acc, next) => acc[next], definitionWithDrivers)
reducerLocation[reducerName] = reducer

[EmrysMyrddin]

You can shorten this with

const [reducerName, reducerPath] = path.split('.')

[bpetetot]

No I dont think you can do that, because reducerName will be the first element and reducerPath the second element of the splitted array.

reducerName must be the last element and reducerPath the rest of the splitted array.

[EmrysMyrddin]

Ha, ok I didn't understand that ^^

[fabienjuif]

Feel free to open a PR if you want to :) Just say it here (or assign issue yourself)

[fabienjuif]

https://github.com/alakarteio/k-redux-factory/pull/116/files#diff-91ab3165bff929a787617811e54b40cbR1