unirakun / k-redux-factory

Factory of Redux reducers and their associated actions and selectors.
MIT License
18 stars 4 forks source link

:sparkles: keyValue / remove by object #120

Closed fabienjuif closed 6 years ago

fabienjuif commented 6 years ago

fixes #118

@EmrysMyrddin This is not really "by reference", because we are looking for the key if the type is object but I guess it is ok like that ? WDYT ?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.009%) to 99.541% when pulling 799ccfebbf8fe707d478579d129f5bdb99a93dbf on remove into ae3763b07248ef64638eb44a3e5b278fe0e8218b on master.

EmrysMyrddin commented 6 years ago

Yes I'm agree with that. It's what I had in mind :-)

fabienjuif commented 6 years ago

Nice, then if you can review this PR it would be cool ;)