Open fabienjuif opened 6 years ago
Yes it seems good to me and useful to avoid problems to avoid name collisions
@bpetetot do you know how to handle dev/prod build from a library perspective ?
In ReactJS, they build 2 differents bundles: react.development.js
and react.production.js
With the following index.js
file:
'use strict';
if (process.env.NODE_ENV === 'production') {
module.exports = require('./cjs/react.production.min.js');
} else {
module.exports = require('./cjs/react.development.js');
}
Hmm ok, so we have to build 2 times the libs:
NODE_ENV=production yarn build
NODE_ENV=development yarn build
And add this index.js manually
I think you can directly build dev and prod bundles through the rollup config. So you will not have to call 2 times the yarn build
command.
I move the lib to microbundle
Only in development builds:
(name, prefix)
[k-redux-factory] You combined two reducers with same name and prefix, we think this is a bug. You should look at 'prefix' option to create your reducer(s)!
@bpetetot are you ok ?
This is related to #73 that is coming back on a regular basis