unirgy / convertm1m2

A simple script to convert extensions from Magento1 to Magento2
MIT License
146 stars 38 forks source link

After Conversion module not working in m2 issue #47

Closed Krupaly2k-zz closed 7 years ago

Krupaly2k-zz commented 7 years ago

Hi Boris,

The extension is really good. I have converted one M1 customer attribute extension which is displaying in my M2 / app/code/ folder but it is showing only etc, composer and registration file. controller and model files are missing in that.

Please guide me on that how can i resolve this issue.

Thanks in advance!

unirgy commented 7 years ago

Is there extension open source? If you can send it to me I can try to figure out the issue

Krupaly2k-zz commented 7 years ago

Sure.

unirgy commented 7 years ago

you can send to unirgy at gmail

Krupaly2k-zz commented 7 years ago

Thanks

Krupaly2k-zz commented 7 years ago

[unirgy at gmail] right?

unirgy commented 7 years ago

yes, but i'd prefer not to have as it on too many public pages to decrease spam

Krupaly2k-zz commented 7 years ago

https://www.magentocommerce.com/magento-connect/manage-customer-attributes-1.html

Try this one. I am trying to convert this extension. Thanks for your quick response

unirgy commented 7 years ago

if you could send me the package, it would be great

Krupaly2k-zz commented 7 years ago

Ok, at which email address should I have to send you?

unirgy commented 7 years ago

the one you asked about

Krupaly2k-zz commented 7 years ago

Clarion_Customerattribute-1.0.2 (2).zip

unirgy commented 7 years ago

It converted properly for me:

chrome_2017-08-10_02-14-54

phpstorm64_2017-08-10_02-14-18

Do you have the extension installed in your magento1 folder?

Krupaly2k-zz commented 7 years ago

Yes, It is installed

unirgy commented 7 years ago

paste the conversion process log

Krupaly2k-zz commented 7 years ago

Ok, I am getting error here Notice: Undefined variable: m in C:\xampp\htdocs\convertm1m2-master\ConvertM1M2.php on line 395

in this line if ($folders && preg_match('#app/code/(core|community|local)/#', $folders[0], $m)) {

unirgy commented 7 years ago

for me this is on line 378. this error doesn't make sense because $m is write only variable in this context

Krupaly2k-zz commented 7 years ago

5

unirgy commented 7 years ago

it should be Clarion, not Calrion...

Krupaly2k-zz commented 7 years ago

Ok, Great. Now it is working fine! Thanks again and sorry for the silly mistake

unirgy commented 7 years ago

Great

unirgy commented 7 years ago

please note, as described in the README that the conversion result is not meant to be final working code, you need to go through all converted files and make sure they have a working as intended code.

unirgy commented 7 years ago

I've just pushed an update, to fix issue with converting consts - pull and rerun the conversion before proceeding please. Thanks

Krupaly2k-zz commented 7 years ago

Hi Boris,

Thanks for the update. Also, please let me know if you have any good solution for M1 to M2 theme migration.

Thanks in advance!

On Aug 10, 2017 3:11 PM, "Boris Gurvich" notifications@github.com wrote:

I've just pushed an update, to fix issue with converting consts - pull and rerun the conversion before proceeding please. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/unirgy/convertm1m2/issues/47#issuecomment-321503520, or mute the thread https://github.com/notifications/unsubscribe-auth/ABk-Bu5PhsKe-QVXp_M-BWNgV27TOvlJks5sWtBFgaJpZM4OzFaU .

unirgy commented 7 years ago

The script moves the files into proper locations and updates the template files as best as it can.. The rest will have to be done manually.

Krupaly2k-zz commented 7 years ago

Hi Boris,

I need some guidance to convert skin and theme folders from M1 to M2. Please let me know if you have good solution for that.

On Thu, Aug 10, 2017 at 3:42 PM, Boris Gurvich notifications@github.com wrote:

The script moves the files into proper locations and updates the template files as best as it can.. The rest will have to be done manually.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/unirgy/convertm1m2/issues/47#issuecomment-321510663, or mute the thread https://github.com/notifications/unsubscribe-auth/ABk-Bkz4_jjJU2lx-H3DsqTMAeoicoaOks5sWteRgaJpZM4OzFaU .