unisonweb / codebase-ui

Unison Codebase UI
https://share.unison-lang.org
MIT License
46 stars 7 forks source link

Move AppHeader back up to App #292

Closed hojberg closed 2 years ago

hojberg commented 2 years ago

Problem

The AppHeader has App specifics, not Page specifics and should not be part of a PageLayout. This prevents us from correctly hooking up interactivity on pages like Catalog, due to the types of Msg being mixed.

Solution

Move AppHeader back up to App and improve the css slightly such that sidebar styling goes in page-layout (should perhaps be in a separate module in a later sidebar cleanup effort)