unisonweb / codebase-ui

Unison Codebase UI
https://share.unison-lang.org
MIT License
46 stars 7 forks source link

Move route specific keyboardshortcuts to pages #297

Closed hojberg closed 2 years ago

hojberg commented 2 years ago

Problem

We don't want Workspace keyboard shortcuts to trigger when on another page like the Catalog.

Solution

Only pass submessages down to sub pages if the corresponding route is active.

Notably this also means that things like the Finder are no longer an App concern, by a Workspace shortcut. There's a few other things that should be moved down a layer like toggling the sidebar, but this should only happen for Share and not for Local (this is not tackled in this effort).

Caveats/Notes

Issues that address things you didn't get to or general notes