search

unisonweb / elm-browser

A Unison Github repo explorer in Elm
MIT License
34 stars 4 forks source link

Make search UX more integrated with module selector #36

Open ashishsc opened 4 years ago

ashishsc commented 4 years ago

Similar to package.elm-lang.org, the search should narrow down the modules that have the string.

giv-elm-pkg

mitchellwrosen commented 4 years ago

Hm, I assigned myself to this ticket, but then unassigned. I actually don't really like the Elm style, it seems a bit limited. Wouldn't you want the main view to contain the terms that you've filtered to, not just the little sidebar?

Anyway, if someone wants to pick this up, the above screenshot would be a welcome improvement, so go for it. i just feel like there's a better design around somewhere...

ashishsc commented 4 years ago

Hmm, what do we want the main view to contain is the real question here.

The documentation + implementations (foldable) of the module is what I would most want probably

As far as filtering out terms in the main view, a lot of the time, the proximity of the terms in a module actually matters (you can design docs to be read top to bottom). I generally like the guidelines here: https://package.elm-lang.org/help/documentation-format

Although my guess here is that unison has no notion of the 'order' in which a module is written?