search

unisonweb / homebrew-unison

2 stars 0 forks source link

adds fzf recommended dependency #3

Closed rlmark closed 2 years ago

rlmark commented 2 years ago

Adds a recommended dependency to the homebrew formula.

I did not opt to bump the version here, as nothing about the binary being built changed, but could be convinced otherwise.

Testing:

locally built with brew reinstall --debug --build-from-source ./unison-language.rb

published a local version of the ucm with version m2k-test and then ran the executable against an existing codebase. 

$  /opt/homebrew/Cellar/unison-language/1.0.M2k-test/ucm --codebase newTest

No issues.

Check dependencies: 

brew info unison-language.rb

==> Dependencies
Recommended: fzf ✔
==> Options
--without-fzf
    Build without fzf support
--HEAD
    Install HEAD version

You can build without fzf with a flag to brew.

aryairani commented 2 years ago

LGTM. I agree with not bumping the version number; it will just be as if everyone who already has m2k installed did so with the --without-fzf flag, and they can always come back and change their minds on that.