unisonweb / ui-core

Shared design system and core components for Unison Local and Unison Share
MIT License
23 stars 4 forks source link

Storybook integration using webpack #58

Closed yoching closed 1 year ago

yoching commented 1 year ago

Added storybook integration using webpack!

If this approach looks good, I'll add more samples.

RelatedPR: https://github.com/unisonweb/ui-core/pull/55

Current samples

Screenshot 2023-03-13 at 16 35 24 Screenshot 2023-03-13 at 16 35 27 Screenshot 2023-03-13 at 16 35 30
hojberg commented 1 year ago

This is really awesome! thanks for taking the time to port to webpack. I'll get this a review today.

hojberg commented 1 year ago

I've updated the main branch with a prettier setup.

yoching commented 1 year ago

Please see this PR for CI errors. https://github.com/unisonweb/ui-core/pull/59

hojberg commented 1 year ago

Merged your PR for the CI fix, after a rebase this should be good to go 🎉

hojberg commented 1 year ago

@yoching Is this ok to mark as ready?

yoching commented 1 year ago

Ok! I was going to add a bit more samples to this, but I can do it later with another PR.

hojberg commented 1 year ago

Yay!! 🎉🎉