unisonweb / ui-core

Shared design system and core components for Unison Local and Unison Share
MIT License
23 stars 4 forks source link

Fix long line overflow #86

Closed yoching closed 8 months ago

yoching commented 8 months ago

Removing max-width: 100vw; from #workspace.view-mode_regular #workspace-content, then adding min-width: 0; to .page-content .columns .column seems to fix the undesired behavior of overflowing long lines.

However, the entire code area width becomes the width of --readable-column-width-medium. Is this the desired behavior?

Screenshot 2024-03-28 at 17 27 17

Reasoning

The source of issue seems to be:

This situation is similar to these known issues:

yoching commented 8 months ago

73

80

hojberg commented 8 months ago

@yoching

Awesome! thank you for looking at this. I think this is the right approach and I've basically have come to realize that most usages of 100vw are not useful.

The code being the full width of the card seems like the right thing. Does it have a scroll inside the card?

hojberg commented 8 months ago

@yoching I think this is basically ready to go—super grateful for this fix 🙏