search

unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.78k stars 270 forks source link

client-side fast-forward check — maybe @ChrisPenner & @aryairani #3189

Open aryairani opened 2 years ago

aryairani commented 2 years ago

a) Just do before check on client, then still construct the history path b) Just do before check on server, no need for client to construct the history path — concern is maybe too much work for server, but we could use a more comprehensive plan for dealing with buggy clients than focusing on this one case.

aryairani commented 4 months ago

@ChrisPenner Do you remember what this was supposed to be about, and whether it's still relevant? And if not, could you close it for being too vague; my bad.

ChrisPenner commented 4 months ago

I believe there were concerns about the fast-forward check being too slow, but at some pointI found out we were doing it in a really slow way, now performance isn't a concern.

I'm not really sure if or where we're currently doing FF checks, but since performance isn't a concern I think we should just close this.