# Avoid infinite loop symlinks.
#   $ find -L . -type l
#   find: File system loop detected;
#     ‘./codebase2/codebase-sqlite/unison’ is part of the same file system loop as
#     ‘./codebase2/codebase-sqlite’.
#   find: File system loop detected;
#     ‘./unison’ is part of the same file system loop as
#     ‘.’.
- arguments:
  - --ignore-glob=codebase2/codebase-sqlite/unison
  - --ignore-glob=unison

Running hlint-3.5 with the above .hlint.yaml, I'm finding 1060 hints when run on .:

Warnings currently triggered

[ ] Avoid lambda, 44 hints
[ ] Avoid lambda using infix, 19 hints
[ ] Avoid reverse, 1 hint
[ ] Eta reduce, 93 hints
[ ] Evaluate, 7 hints
[ ] Functor law, 6 hints
[ ] Fuse foldMap/fmap, 1 hint
[ ] Hoist not, 10 hints
[ ] Monoid law, left identity, 2 hints
[ ] Move brackets to avoid $, 27 hints
[ ] Parse error: on input `|]', 1 hint
[ ] Redundant $, 126 hints
[ ] Redundant <$>, 17 hints
[ ] Redundant as, 1 hint
[ ] Redundant as-pattern, 1 hint
[ ] Redundant bang pattern, 2 hints
[ ] Redundant bracket, 242 hints
[ ] Redundant compare, 2 hints
[ ] Redundant first, 1 hint
[ ] Redundant flip, 7 hints
[ ] Redundant guard, 1 hint
[ ] Redundant id, 2 hints
[ ] Redundant if, 1 hint
[ ] Redundant lambda, 1 hint
[ ] Redundant pure, 14 hints
[ ] Redundant variable capture, 1 hint
[ ] Redundant where, 1 hint
[ ] Replace case with maybe, 13 hints
[ ] Unused LANGUAGE pragma, 127 hints
[ ] Use $>, 7 hints
[ ] Use /=, 2 hints
[ ] Use :, 9 hints
[ ] Use <$, 12 hints
[ ] Use <$>, 32 hints
[ ] Use <&>, 1 hint
[ ] Use =<<, 3 hints
[ ] Use ?~, 2 hints
[ ] Use Just, 1 hint
[ ] Use and, 1 hint
[ ] Use asks, 1 hint
[ ] Use bimap, 6 hints
[ ] Use catMaybes, 2 hints
[ ] Use const, 9 hints
[ ] Use elem, 3 hints
[ ] Use first, 4 hints
[ ] Use fmap, 5 hints
[ ] Use fold, 6 hints
[ ] Use forM_, 1 hint
[ ] Use for_, 1 hint
[ ] Use fromMaybe, 1 hint
[ ] Use gets, 1 hint
[ ] Use guards, 3 hints
[ ] Use id, 1 hint
[ ] Use if, 4 hints
[ ] Use infix, 8 hints
[ ] Use isNothing, 7 hints
[ ] Use isSuffixOf, 1 hint
[ ] Use join, 1 hint
[ ] Use lambda-case, 2 hints
[ ] Use let, 7 hints
[ ] Use list comprehension, 5 hints
[ ] Use list literal pattern, 1 hint
[ ] Use map, 3 hints
[ ] Use map once, 2 hints
[ ] Use mapMaybe, 7 hints
[ ] Use max, 1 hint
[ ] Use maybe, 1 hint
[ ] Use newTMVarIO, 1 hint
[ ] Use newTVarIO, 1 hint
[ ] Use newtype instead of data, 20 hints
[ ] Use notElem, 1 hint
[ ] Use null, 1 hint
[ ] Use record patterns, 17 hints
[ ] Use replicate, 1 hint
[ ] Use second, 11 hints
[ ] Use sequenceA, 3 hints
[ ] Use snd, 1 hint
[ ] Use splitAt, 1 hint
[ ] Use traverse, 2 hints
[ ] Use traverse_, 1 hint
[ ] Use tuple-section, 3 hints
[ ] Use uncurry, 8 hints
[ ] Use unless, 40 hints
[ ] Use unwords, 3 hints
[ ] Use void, 5 hints
[ ] Use when, 3 hints
[ ] Use zipWith, 2 hints

Which of these do we care about?

I'd be prepared to setup a github action to run hlint and to tackle these suggestions, taking the hints and applying them to the unison codebase.

unisonweb / unison

Which hlint hints do we care about? #3747

Warnings currently triggered