search

unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.73k stars 266 forks source link

types/records not rendering right on Share #4524

Open aryairani opened 8 months ago

aryairani commented 8 months ago

Both renders look good in UCM but wrong on Share/Local.

setup

.> clone @zetashift/leer

(snapshotted as @zetashift/leer/@aryairani/issue-4524)

issue 1

@zetashift/leer/main> view core.Feed

  unique type core.Feed = Rss RssFeed | Atom AtomFeed

@zetashift/leer/main> ui core.Feed
image

^ constructor names should be suffixes

issue 2

@zetashift/leer/main> view core.atom.AtomFeed

  unique type core.atom.AtomFeed = { id : Text, title : Text, updated : Text, entries : [Entry] }

@zetashift/leer/main> ui core.atom.AtomFeed
image

^ should render as a record

ChrisPenner commented 8 months ago

Issue 1 is a dup of https://github.com/unisoncomputing/enlil/issues/208

Not quite sure what's up with part two, I'm guessing the selectors missed an update and are now attached to a different record hash (that happens pretty common :'( ) but I'll check and confirm.

EDIT: Oh, didn't see that it works in UCM, that's interesting!

aryairani commented 8 months ago

Also affects Unison Local somehow.