search

unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.64k stars 267 forks source link

hide patches from ls output #5122

Closed mitchellwrosen closed 4 days ago

ceedubs commented 4 days ago

Related: #5084

aryairani commented 4 days ago

closed by #5123

hojberg commented 4 days ago

@mitchellwrosen @ChrisPenner @aryairani does this also remove patches from the codebase server that the local ui relies on (and what about patches on share?)

aryairani commented 4 days ago

@hojberg This only affects what's printed on the screen by the ls command, it doesn't change or remove anything under the hood.

aryairani commented 4 days ago

@hojberg Wait, now I'm not sure.

@mitchellwrosen can you confirm whether the change to Backend.hs affects the local server or Share server (cc @ChrisPenner)

hojberg commented 4 days ago

To be clear: it'd be great if patches didn't show in those places :)

aryairani commented 4 days ago

@hojberg Thanks, that is more clear.

mitchellwrosen commented 4 days ago

@aryairani as far as I can tell this lsAtPath function in the "backend" module is only called from the command-line ls handler (so should probably just be moved there)

aryairani commented 4 days ago

@mitchellwrosen Thanks —  So @hojberg probably no impact to Share or Local