unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.81k stars 271 forks source link

bugfix: tweak suffixify by hash logic #5360

Closed mitchellwrosen closed 2 months ago

mitchellwrosen commented 2 months ago

Overview

Fixes #5357

This PR adds a new "suffixify by hash name" suffixification strategy, which we use whenever rendering definitions to a file.

It's like "suffixify by hash", but won't pick a suffix if it has 2+ matching names where 1+ of them are outside lib. This is because we can't refer to such terms by this suffix if they're in a file.

Test coverage

I've added a transcript