unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.81k stars 271 forks source link

bugfix: fix tdnr + name resolution bug #5370

Closed mitchellwrosen closed 1 month ago

mitchellwrosen commented 1 month ago

Overview

Fixes #5369

This PR fixes the bug demonstrated in #5369. As of this PR, name resolution (logically) works as follows:

Previously, the last step did not properly shadow namespace names with file names, and furthermore was a little out of sync with the "prefer direct deps" rule.

Test coverage

I've added a regression test for #5369, and another big transcript that shows how TDNR works in a number of different situations

aryairani commented 1 month ago

I'm going to merge anyway to help with dogfooding, but we can still tweak the transcripts.