unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.81k stars 271 forks source link

repeat certain CI tests if transcripts/source files change #5386

Closed aryairani closed 1 month ago

aryairani commented 1 month ago

Overview

The integration tests were not being repeated when files they depended on change, and the same was true for round trip tests, leading to a CI failure in trunk due to an improperly skipped test during PR review.

Implementation notes

Adds some more dependents to the ucm binaries cache key and transcript result cache key.

Interesting/controversial decisions

Could have been more granular in either case -- pulling the integration test changes out from the other binaries, or splitting the round trip tests into a separate result cache, but it didn't seem worth the effort.

Test coverage

Loose ends