unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.81k stars 271 forks source link

Update Ormolu version in reformatting workflow #5396

Closed sellout closed 1 month ago

sellout commented 1 month ago

Overview

The workflow that checks for correct formatting was using the correct version (0.7.2.0), but the one that reformats was still using 0.5.2.0.

Loose ends

Ideally, we would only specify the Ormolu version in one place. Currently there are three

The flake could read it from JSON/YAML/whatever (as it already does for Stack, etc.), but it’s annoying at best to read files in GH workflows.

aryairani commented 1 month ago

Yes. It's also annoying that there's no good way (that I know of?) to share a value between multiple CI workflows? I think it needs to be copied into each entry point? Or wait, maybe we could have a custom step in each yaml entry point to read values out of a file, similar to what you proposed the flake could do.