unisonweb / unison

A friendly programming language from the future
https://unison-lang.org
Other
5.81k stars 271 forks source link

feat: implement edit variant that adds to current fold #5404

Closed mitchellwrosen closed 1 month ago

mitchellwrosen commented 1 month ago

Overview

This PR adds a variant of edit (codename edit2) that adds definitions to the top of the file without a fold line below them. It's also careful not to add definitions that already exist in the latest typechecked file.

Test coverage

I've tested this manually and added a transcript.

Loose ends

Rename edit2 to ?

aryairani commented 1 month ago

Let's have edit.new be the existing behavior of adding the fold, edit be the new behavior that does not add a fold, like you'd originally suggested.

mitchellwrosen commented 1 month ago

@aryairani this is ready to go