search

unispeech / unimrcp

Open source cross-platform implementation of MRCP protocol
http://www.unimrcp.org
Apache License 2.0
379 stars 167 forks source link

Add asrclient support for mutliple, builtin and remote grammars #247

Closed schlagert closed 5 years ago

schlagert commented 5 years ago

This is the PR corresponding to #246. I tried to create a minimal patch without any unnecessary whitespace modifications. I also tried to be as close as possible to @achaloyan's surrounding coding style/conventions.

There's no logical changes to the code provided in #246. This patch compiles without any warnings using gcc 9.1.1 on Linux with maintainer-mode enabled. Please note that I haven't tested the resulting asrclient (besides of just starting/exiting it).

It would be great if the original author @michaelplevy could verify the Windows-compatibility as well as the correct functionality.

schlagert commented 5 years ago

I'll leave this open and synced to the extended-asrclient branch until merged.

achaloyan commented 5 years ago

Good. It may take some more time until the changes are merged back to master.

schlagert commented 5 years ago

I'm closing this now since development on the extended-asrclient branch are tested and reviewed now (see #246).