search

unistra / python-glpi-api

Python module for interacting with GLPI using the API.
GNU General Public License v3.0
18 stars 10 forks source link

Do not modify nested input search criteria #11

Closed jplitza closed 2 years ago

jplitza commented 2 years ago

Fixes #10

jplitza commented 2 years ago

Whoops, the original commit also added the original dict to the request. The pop() actually had a reason! ;-)

So I added an exception in the loop that adds all other parameters. The alternative would be to operate on deep clones, but that doesn't seem necessary.

fmenabe commented 2 years ago

Thanks for the PR!

I release a new version on Pypi (0.3.3).

jplitza commented 2 years ago

Thanks for merging!

However, your PyPi release somehow got screwed up. The git tag contains my changes, but the PyPi release doesn't!

fmenabe commented 2 years ago

Sorry, I messed up the generation of the package before uploading it.

A new version (0.3.4) has been released!