Open norihitoishida opened 3 years ago
Hello @norihitoishida, thanks for your suggestion and offering to help! I think that would be a nice addition to our library.
Make sure to check out our guidelines first and to include a couple unit tests. Thanks!
Thanks @LeoTafti !
+1 for that, it's a good idea
Related to #195 , Unittest fails in my development environment.
So I will prioritize resolving #195 .
This shouldn't be a problem on the develop
branch.
I found it more intuitive to use the model.params
attribute instead of the model.get_params()
method (following the fbprophet and statsmodels).
Sorry, due to my personal health issues, I have found that it will take some time to complete this task. Let me close this once.
Take care @norihitoishida
Thank you for your kindness : )
Hello! Firstly, I wanted to thank you for this wonderful library.
Unified API to get model's params might make darts more convenient. For example, to get params of
Exponential Smoothing
model, We have to code like this:So, I want to implement
model.get_params()
method like sklearn.model.params
attribute with property like statsmodels and fbprophet.I would like to get your opinion before send PR. Thanks!
params()
function in theForecastingModel
superclass