search

unitaryfund / metriq-app

Web app for Metriq
https://metriq.info
Apache License 2.0
27 stars 19 forks source link

Include submission image in submission view #249

Closed vprusso closed 2 years ago

vprusso commented 2 years ago

Presently, in the submission scroll an image associated with the submission in question is provided: Screen Shot 2021-11-01 at 8 25 35 PM

However, in the main submission view, the image is not present: Screen Shot 2021-11-01 at 8 25 44 PM

Task

Include the submission image in the submission view.

willzeng commented 2 years ago

Is this closed @vprusso ? I'll close this but do reopen if we are missing something.

vprusso commented 2 years ago

Hmm, I think this may have been closed as either "out-of-scope" or "not-needed" instead of "completed". I'm re-opening this though because it's obvious it's not completed, and based on your comment, I'm assuming you value the image in the submission view. Let me know if I am misinterpreting your intent, but I'll open this up and assign it to myself for now.

willzeng commented 2 years ago

Ah that wasn't it as I interpreted "submission view" as the feed of submissions. I now understand that this means when submitting, which is also a good thing. +1

On Wed, Feb 23, 2022 at 5:24 PM Vincent Russo @.***> wrote:

Hmm, I think this may have been closed as either "out-of-scope" or "not-needed" instead of "completed". I'm re-opening this though because it's obvious it's not completed, and based on your comment, I'm assuming you value the image in the submission view. Let me know if I am misinterpreting your intent, but I'll open this up and assign it to myself for now.

— Reply to this email directly, view it on GitHub https://github.com/unitaryfund/metriq-app/issues/249#issuecomment-1049273521, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZDATNIDWSWHZIKPKNDTDU4VNDVANCNFSM5HFHAUBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

-- https://unitary.fund/ Creating a quantum technology ecosystem that benefits the most people.