unitaryfund / metriq-app

Web app for Metriq
https://metriq.info
Apache License 2.0
27 stars 19 forks source link

Issue: Click on menu items when logged in yields flashing of menu items #69

Closed vprusso closed 3 years ago

vprusso commented 3 years ago

When logged into MetriQ, the user is presented with the following set of menu items:

Screen Shot 2021-08-04 at 5 57 07 AM

Clicking on any one of these menu items seems to briefly alter these items to display as if the user was not logged in. It only occurs for a fraction of a section, but the following menu of a non-logged-in user is visible:

Screen Shot 2021-08-04 at 5 56 54 AM
WrathfulSpatula commented 3 years ago

Adding wontfix label, for now, so that my eyes scan past this when I glance at the issue list.

This is a known issue with common use cases of React.js, basically, but that doesn't mean it's ultimately impossible to surmount. It's just not high-priority, at the moment.

vprusso commented 3 years ago

I believe what you did in this PR: https://github.com/unitaryfund/metriq-app/pull/105 inadvertently made this issue go away as well. Whether it was this PR or not, the issue seems to not be present, so I'll close, but reopen if you disagree.