search

unitaryfund / metriq-client

Fork of papers-with-code client
https://metriq.info
Apache License 2.0
3 stars 10 forks source link

Add ability to edit results? #10

Closed rmlarose closed 3 years ago

rmlarose commented 3 years ago

For a test submission I created an example result:

Screenshot from 2021-08-14 13-59-44

But I entered the wrong number of qubits! I can change this by deleting the result then adding a new one. The faster route would be editing the result - thoughts on supporting this?

vprusso commented 3 years ago

Definitely a good point. In some sense, I think this is already supported on the client-side (@WrathfulSpatula you can let me know if I'm saying something incorrect here).

Basically, for metriq-client, you could make a submission update where the only updated field is the field you wish to have changed; in this case, the "value".

I'm a bit less sure about the "best" way to modify the metriq-app component to allow this flow, but I imagine we could just make those fields editable? Any thoughts @WrathfulSpatula?

WrathfulSpatula commented 3 years ago

Personally, I like having the minimal number of user stories and simplest user interface that enables the functionality the user needs. I'd ask, is there any particular problem with deleting an incorrect result and adding a new one in its place? We do save the "soft-deleted" old result in the database, but it's out of tabulation and statistics, so it doesn't seem to make a difference, to me.

vprusso commented 3 years ago

Gotcha. In that case, I think I agree with @WrathfulSpatula on minimizing the user stories. Any strong opposition, @rmlarose ?

rmlarose commented 3 years ago

Nope! It might come up again but I'm fine closing this, SGTM.