search

unitaryfund / metriq-client

Fork of papers-with-code client
https://metriq.info
Apache License 2.0
3 stars 9 forks source link

Client result getter return type #111

Closed karlaspuldaro closed 11 months ago

karlaspuldaro commented 1 year ago

MetriqClient result_get() is expected to return a Result item not a Method - need to fix function signature, description and uncomment return line.

vprusso commented 12 months ago

Thank you for opening this, @karlaspuldaro !

Hmm, as it turns out, the GET endpoint for a Result object is not supported via the metriq-api. So, in order to fix this issue, I'm going to all together remove the result_get method as the end-point isn't supported:

For reference: https://github.com/unitaryfund/metriq-api/blob/e7f5b99dfcb516fbaf5f04ea62c89796b3cca472/metriq-api/api-routes.js#L132C2-L132C2

I'll open up a PR shortly for this.

karlaspuldaro commented 12 months ago

Would it be helpful to open an issue to add a get endpoint for client results? Could be useful to use the API to keep track of what's submitted and identify result items to be updated.

vprusso commented 12 months ago

That's true, I could see that being a probable use case. If you think you could benefit from such a feature, by all means, we would welcome your input and feedback by opening such an issue! Just wanted to reiterate that all of the issues you've opened thus far have been incredibly helpful. We sincerely appreciate your support and attention to detail--thank you again, @karlaspuldaro !