Migrated from `setup.py` to `pyproject.toml`

unitaryfund / metriq-client

Fork of papers-with-code client

https://metriq.info

Apache License 2.0

3 stars 9 forks source link

Migrated from `setup.py` to `pyproject.toml` #121

Closed AVDiv closed 2 months ago

AVDiv commented 3 months ago

Replaced the setup.py with pyproject.toml.

Now the project could be installed using the python3 -m build command.

Related Issue: #119

vprusso commented 3 months ago

Hi @AVDiv ,

Thanks for the contribution!

A few minor comments, but it's looking good:

It looks like setup.py.old should be removed.
Is it possible to install this package via poetry install -> poetry shell? I think this would just require a [tool.poetry] heading with a few elements in the pyproject.toml file.

Thanks again!

AVDiv commented 3 months ago

I'll work on it

AVDiv commented 3 months ago

[x] Removed old setup file (setup.py)
[x] Changed the build system to poetry, now the package is installable using the poetry install command.

vprusso commented 3 months ago

Wonderful. I was able to poetry install -> poetry shell and it works great.

As one final check, let me just ping @WrathfulSpatula to see if there's anything else I might be missing, but for me LGTM! Great work, @AVDiv , and I hope to see more contributions from you.

vprusso commented 2 months ago

Thank you again for your contribution, @AVDiv. I've since assigned you the task and merged your code.

Thanks as well to @WrathfulSpatula for the review as well!

AVDiv commented 2 months ago

Welcome @vprusso, but this PR is not being listed on the unitaryhack leader-board, Can you please check it out

vprusso commented 2 months ago

You are correct. I assigned you to the issue itself. Thanks for letting me know!