willzeng
commented
3 weeks ago Great add!
Will Zeng President Unitary Fund - because evolution is unitary
Unitary Fund https://unitary.fund/ | Linkedin https://www.linkedin.com/company/unitary-fund/ | X https://x.com/home?lang=en | Discord https://discord.com/invite/unitary-fund-764231928676089909
On Mon, Nov 11 2024 at 12:26 PM, Vincent Russo @.***> wrote:
@.**** approved this pull request.
One minor request for longer line length for formatter but LGTM!
In pyproject.toml https://github.com/unitaryfund/metriq-gym/pull/22#discussion_r1836994101 :
@@ -21,6 +21,13 @@ metriq-client = { git = "https://github.com/unitaryfund/metriq-client.git", bran matplotlib = "^3.9.2" qiskit-experiments = "^0.7.0"
+[tool.poetry.group.dev.dependencies] +ruff = "^0.7.3" +pre-commit = "^4.0.1" + +[tool.ruff]
Can we add:
line-length = 120
80 is annoyingly conservative
— Reply to this email directly, view it on GitHub https://github.com/unitaryfund/metriq-gym/pull/22#pullrequestreview-2427818773, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZDAQYWPUGYMDV2XLVP4T2ADSEHAVCNFSM6AAAAABRSH5JV6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRXHAYTQNZXGM . You are receiving this because you were mentioned.Message ID: @.***>
Setting up Ruff (the same tool used in Mitiq), so we don't have to care about linting and formatting (new lines, unused vars, etc..) in each PR, and we can focus on the important things.
Notes:
Current Python version (3.12.7) is not allowed by the project (3.12).(cc @willzeng)/metriq_gym/hardwaredon't go through Ruff, because they are copied verbatim from https://github.com/qiskit-community/qiskit-device-benchmarking/ and the less we touch them, the easier it will be to keep them in sync with upstream (until we get to create our original versions of those benchmarks)