unitaryfund / mitiq

Mitiq is an open source toolkit for implementing error mitigation techniques on most current intermediate-scale quantum computers.
https://mitiq.readthedocs.io
GNU General Public License v3.0
363 stars 160 forks source link

Images in docs might not appear as intended in dark mode #1547

Open purva-thakre opened 2 years ago

purva-thakre commented 2 years ago

When RTD is displayed in dark mode, some of the images with dark borders appear cutoff. Those with white backgrounds and dark borders also appear cutoff and a little bit squashed.

Here's a comparison for one of the CDR images.

image image

natestemen commented 2 years ago

I'm not totally sure what the solution here is. Do you think the white background should be extended further around the image so the black background from dark-mode doesn't butt right up against the image?

purva-thakre commented 2 years ago

Yeah, I was thinking it would be better to increase the dimensions of the white background. And make this background consistent for all images in the documentation.

There are some images without a solid white background layer as well. They appear dim in dark mode (couldn't think of a better term) which I guess is the intention of dark mode.
image image

jordandsullivan commented 7 months ago

I'm not quite seeing the issue in these images? The dark mode images seem to appear fine for me. Is there information getting cut off?

purva-thakre commented 7 months ago

Is there information getting cut off?

Not really.

It's more about how there's a transparent layer underneath all images. The comparison in the description is the issue at hand. If we switch from light to dark mode, a consistent white layer underneath all images would help avoid dark mode creeping up close and behind the images.