Draft PR workflow handles separated tests improperly

unitaryfund / mitiq

Mitiq is an open source toolkit for implementing error mitigation techniques on most current intermediate-scale quantum computers.

https://mitiq.readthedocs.io

GNU General Public License v3.0

363 stars 160 forks source link

Draft PR workflow handles separated tests improperly #1851

Closed Aaron-Robertson closed 1 year ago

Aaron-Robertson commented 1 year ago

Issue Description

When a change is made to /mitiq/interface/conversions.py testing will fail (and likely applies to any change where tests are separate from the code, i.e. code tested in /mitiq/tests/).

How to Reproduce

See the draft PR workflow runs from #1850.

Suggested Solution

We should make sure to ignore pyquil tests, and in draft PRs may want to either ignore the /mitiq/tests/ directory, or run it by default.

Misty-W commented 1 year ago

Nice to have, not sure if possible/practical: Codecov report (at least the “patch” coverage report) on draft PRs.

natestemen commented 1 year ago

We removed the draft PR workflow in https://github.com/unitaryfund/mitiq/pull/2019, closing.