search

unitaryfund / mitiq

Mitiq is an open source toolkit for implementing error mitigation techniques on most current intermediate-scale quantum computers.
https://mitiq.readthedocs.io
GNU General Public License v3.0
363 stars 160 forks source link

Failure of non-linux draft tests #1974

Closed purva-thakre closed 1 year ago

purva-thakre commented 1 year ago

Discussed in https://github.com/unitaryfund/mitiq/discussions/1973

Originally posted by **purva-thakre** August 23, 2023 I have a WIP PR (#1963). I know it is failing 'validate' because I have ignored to account for type checking. Even then, all of the non-linux Windows tests are failing with a similar message across all of them. Is this unrelated to the PR and should be ignored for now? https://github.com/unitaryfund/mitiq/actions/runs/5959506725/job/16165346786?pr=1963 https://github.com/unitaryfund/mitiq/actions/runs/5959506725/job/16165346846?pr=1963 https://github.com/unitaryfund/mitiq/actions/runs/5959506725/job/16165346917?pr=1963 https://github.com/unitaryfund/mitiq/actions/runs/5959506725/job/16165347000?pr=1963 Edit: Tried a bunch of different `fetch depth` options. All of them led to the Windows draft build failing. Why does the build for mac pass but fail for windows? Edit2: If `fetch_depth = 2`, mac build passes but windows build fails. If `fetch_depth = 0`, windows build passes while mac build fails. I think this is unrelated to my current PR. I followed this [answer on StackOverflow](https://stackoverflow.com/a/76769122/10241324) to set `fetch_depth = 0`.
purva-thakre commented 1 year ago

Easy option to fix this issue : split test-nonlinux-draft into test-non-linux-draft-mac with fetch_depth = 2 and test-non-linux-draft-windows with fetch_depth=0.