Closed cosenal closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.23%. Comparing base (
5365e7a
) to head (98f2080
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The codecov/project failure looks like a hiccup on codecov side. Upon inspection of the coverage report there are no files affected.
Hm, do you know why codecov is complaining that this line was an "indirect change?" https://app.codecov.io/gh/unitaryfund/mitiq/pull/2312/indirect-changes
Hm, do you know why codecov is complaining that this line was an "indirect change?" https://app.codecov.io/gh/unitaryfund/mitiq/pull/2312/indirect-changes
It's unrelated to this PR. What is happening is that the order in which the tests get executed affects that line. Since the order test is random, that line ends up being covered or not. In fact, if you look at the list of recent coverage reports, you can see the score oscillates between 98.29% and 98.33%. I will try to find the root cause of this "non-determinism"
@jordandsullivan Please take another look. This time the codecov makes sense, as I removed those 4 test files from the coverage.
Description
tests
otherwise the tests themselves are picked up by codecov, because of this: https://github.com/unitaryfund/mitiq/blob/8c24a9bddd4d6213cdd39fae2d750e55247e82a9/.coveragerc#L3