Updated link to mitiq logo

unitaryfund / mitiq

Mitiq is an open source toolkit for implementing error mitigation techniques on most current intermediate-scale quantum computers.

https://mitiq.readthedocs.io

GNU General Public License v3.0

344 stars 145 forks source link

Updated link to mitiq logo #2336

Closed jordandsullivan closed 2 months ago

jordandsullivan commented 2 months ago

Description

Updated the link to the mitiq logo image in the Readme. This fixes the broken link failing to display the logo in the documentation: https://mitiq.readthedocs.io/en/stable/.

This fix works on my local build.

License

[x] I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

[ ] I added unit tests for new code.
[ ] I used type hints in function signatures.
[ ] I used Google-style docstrings for functions.
[ ] I updated the documentation where relevant.
[ ] Added myself / the copyright holder to the AUTHORS file

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.22%. Comparing base (9a90339) to head (56cb650).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2336 +/- ## ======================================= Coverage 98.22% 98.22% ======================================= Files 87 87 Lines 4052 4052 ======================================= Hits 3980 3980 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jordandsullivan commented 2 months ago

I am not sure how to trigger the docs to rebuild from source on https://mitiq.readthedocs.io/en/stable/ though. Does this only happen once per milestone?

purva-thakre commented 2 months ago

Does this only happen once per milestone?

On stable, yes. You can only see the changes after each milestone.

I don't see the changes from this PR in the latest version though: https://mitiq.readthedocs.io/en/latest/

jordandsullivan commented 2 months ago

Hm, odd. Is there an extra step that needs to be triggered manually?

purva-thakre commented 2 months ago

I don't think so. The merged PR should have shown up in the latest version. Maybe there's another reason for the broken logo.

cosenal commented 2 months ago

The problem is that RTD latest points to master and not main

jordandsullivan commented 2 months ago

I see others have had this issue too: https://github.com/readthedocs/readthedocs.org/issues/7907

cosenal commented 2 months ago

We can just go to our RTD profile and fix it manually, but I don't have the credentials. I asked in the our internal chat.

cosenal commented 2 months ago

Fixed it. Build is in progress now. As soon as it's done, latest should point to main. Thanks for spotting this.