Remove qiskit-ibm-provider

andre-a-alves commented 6 months ago

Description

Removes qiskit-ibm-provider.

qiskit-ibm-provider is deprecated, and should be migrated to qiskit-ibm-runtime using the migration guide. The only use of qiskit-ibm-provider was in the docs, so this MR updates the docs to no longer use the deprecated module and drops the module from the mitiq[qiskit] requirements.

I let most of the examples send a circuit to IBM Quantum, and minor discrepancies in the code have been corrected from that as well.

This MR should also make dependabot MR #2306 unnecessary.

License

[X] I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

[ ] I added unit tests for new code.
[ ] I used type hints in function signatures.
[ ] I used Google-style docstrings for functions.
[X] I updated the documentation where relevant.
[ ] Added myself / the copyright holder to the AUTHORS file

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.22%. Comparing base (2ff8134) to head (ddf7147).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2342 +/- ## ======================================= Coverage 98.22% 98.22% ======================================= Files 87 87 Lines 4059 4059 ======================================= Hits 3987 3987 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andre-a-alves commented 6 months ago

I had to add the requirement for qiskit-ibm-provider back in for Pennylane on Python 3.9. A TODO is included to remove it when Pennylane gets upgraded.

andre-a-alves commented 6 months ago

After upgrading Pennylane, qiskit-ibm-provider~=0.11.0 still needs to remain a requirement in requirements-pennylane.txt for Python 3.9 until qiskit-ibm-runtime is upgraded. The comment was updated.

cosenal commented 6 months ago

Thanks for resolving the conflicts, @andre-a-alves, LGTM. Feel free to merge if you think it's ready to go.

unitaryfund / mitiq