Open purva-thakre opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.68%. Comparing base (
aefc5ce
) to head (891b9b5
). Report is 18 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@cosenal This one's ready to be merged as well. Unless we don't want to ignore this file from the pytest coverage report.
Should there be tests for this function, however?
I was confused if this file needs to have unit tests. # pragma: no cover
was selectively used in that file before I added the entire file to ignore in coveragerc
I was confused if this file needs to have unit tests.
A test that ensures mitiq.about()
returns a string seems reasonable. I wouldn't want to test much more than that, however. Definitely low priority.
A test that ensures mitiq.about() returns a string seems reasonable.
Output of mitiq.about()
is NoneType
not str
. Mostly because we use print
to return the output of mitiq.about()
.
Output of mitiq.about() is
NoneType
notstr
.
You're right! I shouldn't have said "... returns a string".
Exactly as you say, the type annotations denote return types, without any indication if something is printed to standard out, standard error, or any other external action is taken. What I'm lightly suggesting (again, low priority) is we ensure that mitiq.about()
prints to standard out.
Related to two of the items in #2365