Open dependabot[bot] opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.30%. Comparing base (
5880803
) to head (6c016fb
). Report is 11 commits behind head on main.:exclamation: Current head 6c016fb differs from pull request most recent head ad9249d
Please upload reports for the commit ad9249d to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In mitiq/benchmarks/randomized_benchmarking.py
we use _gate_seq_to_mats
from 'cirq.experiments.qubit_characterizations' and that function is no longer there in cirq 1.4.0.
In fact, we should not have code that depends on functions (from external modules) that are intended for internal use (single underscore functions).
Doing a quick search, I also found:
mitiq/benchmarks/mirror_circuits.py
uses _single_qubit_cliffords
from cirq.experiments.qubit_characterizations
.
mitiq/pec/types/types.py
uses _format_coefficient
from cirq.value.linear_dict
Both of these functions still exist. _format_coefficient
has remained the same for 5 years, while _single_qubit_cliffords
was slightly updated in January 2024.
Thanks, @bdg221. Ideally we want to get rid of all of those cirq internal function calls in Mitiq.
The solution I implemented in commmit ad9249d in this PR only works with cirq-core>=1.4.0
. The solution relies on another internal function, _reduce_gate_seq
, which was introduced only in Cirq 1.4.0.
This makes the tests break at the moment. However, if we want to support Python 3.12 and drop Python 3.9, we will want to enforce a dependency to cirq-core>=1.4.0
anyway, in which case commit ad9249d will be a valid solution. This will have to come all together in #2066 (cc @natestemen)
A newer version of cirq-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.
Updates the requirements on cirq-core to permit the latest version.
Release notes
Sourced from cirq-core's releases.
... (truncated)
Commits
ab96766
Fix expected package version in the tests8aa1725
Removing 1.4.0.dev -> 1.4.0ab86979
Flush deprecations before minor release (#6622)a9776d0
Nicer string representation for InverseCompositeGate (#6262)2cfdf1f
Add convenience methods to create PhasedXZ gate from ZYZ decomposition (#6569)1a8caa4
Proper text files end with a newline character (#6614)778e9e9
Freshen-up cirq dependencies (#6616)e4b6ab2
Fix spurious failure of the check/all script (#6611)ee4d702
enable simulation of controlled gates in classical simulator (#6589)528b2d2
Update list of pre-release notebooks (#6609)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show