Issue #2354 Fix - qiskit QFT gates error during conversion

NnguyenHTommy commented 3 months ago

fixes issue #2354 where a QFT qiskit circuit would error out during conversion. Implemented a fallback mechanism to decompose and transpile the qiskit circuit into native gates. Added a unit test in the ZNE module to test this with qiskit's QFT gate.

This is my first open source contribution via unitary hack so any feedback would be appreciated!

Description

License

[ x] I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

[x ] I added unit tests for new code.
[ x] I used type hints in function signatures.
[ x] I used Google-style docstrings for functions.
[x ] I updated the documentation where relevant.
[ x] Added myself / the copyright holder to the AUTHORS file

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.32%. Comparing base (837ea83) to head (bcd3ff1). Report is 45 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2404 +/- ## ========================================== + Coverage 98.30% 98.32% +0.01% ========================================== Files 87 87 Lines 4003 4048 +45 ========================================== + Hits 3935 3980 +45 Misses 68 68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cosenal commented 3 months ago

@NnguyenHTommy Thanks for your second revision on this PR. I left some replies on the comments.. we are very close to merge this!

unitaryfund / mitiq