search

unitaryfund / mitiq

Mitiq is an open source toolkit for implementing error mitigation techniques on most current intermediate-scale quantum computers.
https://mitiq.readthedocs.io
GNU General Public License v3.0
358 stars 157 forks source link

Github CI tests master as well as the opened branch #78

Closed willzeng closed 4 years ago

willzeng commented 4 years ago

There is an example of this in #72

Strangely the github actions CI is not behaving as expected. The failing tests here are failing because of the flake8 problem on master (see #76 ) not because of code on this branch.

The tests that pass are just testing this branch, which does pass.

It isn't clear to me why the pull_request trigger is testing the master branch.

Any ideas?

nathanshammah commented 4 years ago

I think we sorted out this difference and maybe we can close this issue if it's fine.

One thing I'd like to point out is that, with PR #123 (closing issue #121), which adds Mac and Windows build in CI, we have added cloud minutes that are counted in for billing purposes. So far so good, but maybe this is something to keep an eye on.

Screenshot 2020-04-20 11 23 36

There's been recently (April 14th) an announcement on free features for teams that I haven't understood if impacts us at all, as the organization has a billed account.

willzeng commented 4 years ago

Good call. That's good to be aware of as we'll want to watch our spending on testing.

On Mon, Apr 20, 2020 at 5:52 AM Nathan Shammah notifications@github.com wrote:

I think we sorted out this difference and maybe we can close this issue if it's fine.

One thing I'd like to point out is that, with PR #123 https://github.com/unitaryfund/mitiq/pull/123 (closing issue #121 https://github.com/unitaryfund/mitiq/issues/121), which adds Mac and Widows build in CI, we have added cloud minutes that are counted in for billing purposes. So far so good, but maybe this is something to keep an eye on. [image: Screenshot 2020-04-20 11 23 36] https://user-images.githubusercontent.com/14573436/79738500-1fcbad00-82fd-11ea-916f-ccfae613a87f.png

There's been recently (April 14th) an announcement https://github.com/pricing on free features for teams that I haven't understood if impacts us at all, as the organization has a billed account.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/unitaryfund/mitiq/issues/78#issuecomment-616439006, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZDAWXZXCTUW2KEMIONW3RNQLNLANCNFSM4LXY5XMA .

-- https://unitary.fund/ Creating a quantum technology ecosystem that benefits the most people.

nathanshammah commented 4 years ago

Getting back to that discussion on features to provide to UF microgrants recipients, including stuff such as GH Pro profiles, and the possibility to contact GH directly, I found out this:

https://github.com/nonprofit

I think we could definitely apply – and see if we can save the GH org fee for UF, to begin with.