Closed nathanshammah closed 4 years ago
@nathanshammah
I'll proceed.
I had to modify a bit the setup.py and struggle a bit but now it's on: https://test.pypi.org/project/mitiq/ (the build badge I think doesn't render as the repo is private.) I'll add also on pypi main channel.
By installing with
pip install -i https://test.pypi.org/simple/ mitiq
in an empty python 3.8 miniconda environment, I get this error message
ERROR: Could not find a version that satisfies the requirement numpy>=1.18.2 (from mitiq) (from versions: 1.9.3)
ERROR: No matching distribution found for numpy>=1.18.2 (from mitiq)
although I just updated miniconda. I changed the requirements from numpy==1.18.2
to numpy>=1.18.2
, but that should not be an issue.
I don't get it with the pip install .
, done locally. However, after installing separately pip install numpy>=1.18.2
(and uninstalling mitiq), re-installing mitiq from test-pypi works.
Numpy v1.18.2 is not bleeding edge, but very very recent (anaconda hosts only v1.18.1, updated 11 days ago). Maybe, if everything works fine, we could downgrade to lower versions if we do not need so recent versions. Still I don't get why the package is not collected, as it should use pip.
By the way, I saw that another way to set requirements is numpy~=1.18.2
, which will install an updated micro, but not a new macro, for backward compatibility.
We need to add scipy to dependencies, as it's now called in factories.py
from scipy.optimize import curve_fit
Anyways, this is just to have a placeholder.
It's also registered on pypi, you can check with pip install mitiq==0.0.0
.
@nathanshammah Is there anything left to do on this issue? I'm going to close it but otherwise please do reopen.
It could be nice to do a private Github release as we close milestone 2, cc @willzeng. This way we can also add to the internal report and pre-alpha users that we have a release (albeit not public).
I'm on board. Let's do an alpha release when milestone 2 closes. (Nothing on pypi yet)
On Tue, Jun 2, 2020, 5:36 AM Nathan Shammah notifications@github.com wrote:
It could be nice to do a private Github release as we close milestone 2, cc @willzeng https://github.com/willzeng. This way we can also add to the internal report and pre-alpha users that we have a release (albeit not public).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unitaryfund/mitiq/issues/80#issuecomment-637420389, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZDAWF5M27U6WPJR2CJE3RUTBYBANCNFSM4LY6TSDA .
mitiq
on pypi and test-pypi, as some package and related info needs to be uploaded. Not sure if they would allow an empty package to be there.