search

unitaryfund / qrack

Comprehensive, GPU accelerated framework for developing universal virtual quantum processors
https://qrack.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
177 stars 38 forks source link

Fix hyper-separation on approximate separability. #728

Closed WrathfulSpatula closed 3 years ago

WrathfulSpatula commented 3 years ago

This fixes #727, by leaving basis change up to TrySeparate() rather than ProbBase().

WrathfulSpatula commented 3 years ago

I was confused, by the best approach to this: this is equivalent to setting the separability threshold to (1-1/Sqrt(2))/2. That's how this should be done, while users are allowed to separate even more aggressively.