search

united-manufacturing-hub / benthos-umh

Apache License 2.0
31 stars 10 forks source link

added ads plugin and readme #35

Closed RuneRoven closed 4 months ago

RuneRoven commented 8 months ago

Added ads plugin and changed readme. Import for new package still need to be changed in the main file. Import for ads native package is local so that might need to be changed.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

JeremyTheocharis commented 7 months ago

good clean up. you made some changes in the symbol reading with the offset? Why? also in the test suite, make sure the ams net id on the target is correct, it is not always the same as the ip + .1.1 however on the client side this is usually the case

The offset was actually never used, and I got a warning from the go static checker that the variable was never used. So I removed it. Maybe it indicates a logic error of some sort, that an offset should be used but was not used?

Still need to write the test fully

JeremyTheocharis commented 4 months ago

We have now merged it using a different method :)