search

unitedstates / bill-nicknames

Table of popular nicknames and keywords for bills, curated manually.
The Unlicense
55 stars 15 forks source link

Update bill-nicknames.csv #3

Closed irosenb closed 12 years ago

irosenb commented 12 years ago

I'm adding in the NDAA bill, as it received significant attention at the end of 2011, for its provisions on indefinite detention.

konklone commented 12 years ago

This is great, thanks for making the first community contribution, :) Just a couple things -

Could you update this to put quotes around the comment? It's got a comma in it, so in some CSV readers this will break the comment up into multiple cells unless it's quoted. There's also a stray space at the beginning of the cell.

Also, I think we'll want this to match on both the House and Senate versions of the bill, since the Senate one (S 1867) got lots of Congressional activity as well.

FWIW, the acronym "NDAA" does appear in the bill's official text, and official summary, so it should come up already if a user searches for "ndaa" in any decent bill search engine. But I'm happy to include this, especially because having it be known in the data that it's a bill's "nickname" could potentially produce better ordering of results by relevance.

Example of what a search for "ndaa" right now gives back for bills, when matching on summary, text, keywords, nicknames, and titles: http://scout.sunlightfoundation.com/search/federal_bills/ndaa

irosenb commented 12 years ago

Thank you, this is actually my first commit on Github and therefore my first open source contribution ever, so I'm a little confused. How do I go back and edit this pull request?

irosenb commented 12 years ago

Got it! I added the senate version of the bill as well, and put quotes around the comments.

konklone commented 12 years ago

Great, merged it. Thank you, Isaac!