Remove entries from committee-membership-current when retiring members

unitedstates / congress-legislators

Members of the United States Congress, 1789-Present, in YAML/JSON/CSV, as well as committees, presidents, and vice presidents.

Creative Commons Zero v1.0 Universal

2.04k stars 507 forks source link

Remove entries from committee-membership-current when retiring members #173

Open GPHemsley opened 10 years ago

GPHemsley commented 10 years ago

I'm currently hitting an error because the member with THOMAS ID '00021' was retired (i.e. move from legislators-current to legislators-historical) but their entry in committee-membership-current was not removed, so the member lookup when parsing the committee membership is failing due to an unknown ID.

I think it would make sense to update the retire script to also remove entries from committee-membership-current.

JoshData commented 10 years ago

I guess the question is, what happens if the committee membership scraper is run after?

Maybe the thing to do is to revise that scraper and have it skip members that aren't in legislators-current. Then we'll need to remember to re-run that scraper after retirements.