unitedstates / congress-legislators

Members of the United States Congress, 1789-Present, in YAML/JSON/CSV, as well as committees, presidents, and vice presidents.
Creative Commons Zero v1.0 Universal
2.06k stars 505 forks source link

116th Congress Committee Assignments #661

Closed dwillis closed 5 years ago

dwillis commented 5 years ago

This PR updates House and Senate committee and subcommittee assignments for the 116th Congress. There are some important notes:

  1. It adds a start_date and source attribute to assignments, tied to House/Senate resolutions announcing membership or committee press releases announcing subcommittee assignments. Both are optional.
  2. There are a handful of committees and subcommittees without current assignments. These include all of the joint committees and some of the select committees (including House select committees on climate change and modernization of Congress). The new select committees also are not yet in the committees_current.yaml file.
  3. There is one subcommittee, Elections of House Administration, that is new and does not yet have either a clerk code or what we call a thomas_id. I've temporarily called this subcommittee HSHA01 with a thomas_id of 01.
  4. Where subcommittee assignments specifically mention Ex Officio roles for the full committee chair and ranking member, they are included.
  5. Vacancies are not included.
JoshData commented 5 years ago

Wow. Thank you so much for posting all this. It's a lot --- I'll give it a quick look over this weekend.

JoshData commented 5 years ago

The linter test actually picked up a little problem - two start dates on one entry:

   start_date: '2019-01-15'
   start_date: '2019-01-29'

After that's resolved, do you mind if I squash the commits so we have a single clean commit with all of this work, or would you rather I preserve the branch history with a regular merge?

We should also add documentation for the new start_date and source fields (later is fine by me). And I'm not sure how the new fields will interact with our scripts to gather committee membership (after running the script the new fields will probably disappear), so we may be stuck on pulling membership updates until we figure that out.

dwillis commented 5 years ago

Fixed dupe start date in https://github.com/unitedstates/congress-legislators/pull/661/commits/899d6ecc7e11f88e83902e8ba014fc7180794b03