search

unitedstates / congress-legislators

Members of the United States Congress, 1789-Present, in YAML/JSON/CSV, as well as committees, presidents, and vice presidents.
Creative Commons Zero v1.0 Universal
2.03k stars 502 forks source link

Missing Committee Members #886

Closed mattpaz closed 1 year ago

mattpaz commented 1 year ago

There seem to be many subcommittees (like HSSY20) that don't include the members.
If these are manually curated, I'd image a PR would be welcome?

https://github.com/unitedstates/congress-legislators/blob/main/committee-membership-current.yaml#L4476

JoshData commented 1 year ago

It's updated by https://github.com/unitedstates/congress-legislators/blob/main/scripts/committee_membership.py from XML data from the House and Senate. We run the script manually periodically. I just ran it and pushed the update.

mattpaz commented 1 year ago

Ah, cool. I didn't realize that xml data existed. Thanks for pointing me in the direction of the python code and for running an interim update too.

The updates definitely filled in some gaps!

I'll take a deeper look at the python script and upstream sources at some point. In the meantime, I'll just cite some of those that still have no subcommittee members listed.

HLIG03
HLIG05
HLIG08
HLIG10
HSBA13
HSBA15
HSED07
HSGO02
HSGO25
HSGO28
HSGO29
HSHA01
HSII22
HSRU05
HSSM25
HSSM26
SSCM26
SSCM27
SSCM28
SSCM29
SSCM30
SSCM31
SSCM32
SSEV16
SSEV18
SSFR12
SSFR13
SSGA15
SSGA16
SSGA17
SSGA18
SSGA19

Looking at the committees_current source, perhaps it simply needs to be reviewed/updated to reflect current committees before re-running the script?

I wonder if we could use this: https://api.congress.gov/#/committee/committee_list as a good source for updates?

https://api.congress.gov/v3/committee/118?limit=250&api_key=TBD

I'll try to compare the data in the congress.gov apis to the data in committee_current at some point (if someone doesn't beat me to it).

UPDATE:

I've only spot checked a few, but just observing that SSCM26 (for example) is listed in the congress.gov apis too, but it does not seem to be represented in either of these two sources:

🤔 Not quite sure what to make of that yet, but maybe someone has thoughts/insights. Perhaps it implies that subcommittees like SSCM26 are simply stale/old/defunct?

Thanks again!

JoshData commented 1 year ago

It's also possible the subcommittee has no members or that it exists only on paper. But defunct might be the most likely.

mattpaz commented 1 year ago

I've completed a review of the defunct committees and have a PR started here: https://github.com/unitedstates/congress-legislators/pull/890

Take a look and let me know if I missed anything.

mattpaz commented 1 year ago

With https://github.com/unitedstates/congress-legislators/pull/890 committed, I think we can probably close this issue.