search

unitedstates / congress-legislators

Members of the United States Congress, 1789-Present, in YAML/JSON/CSV, as well as committees, presidents, and vice presidents.
Creative Commons Zero v1.0 Universal
2.03k stars 502 forks source link

#886 - Update/defunct or dup committees #890

Closed mattpaz closed 1 year ago

mattpaz commented 1 year ago

I did a manual audit of #886 and indeed, it looks the committees missing members are no longer listed in applicable house/senate websites.

Wasn't sure if committees-historical.yaml should be manually updated in concert (I'm not currently using it).

JoshData commented 1 year ago

Wasn't sure if committees-historical.yaml should be manually updated in concert (I'm not currently using it).

It's possible it already has these committees. Can you check? If so, we should be OK to merge this.

mattpaz commented 1 year ago

Wasn't sure if committees-historical.yaml should be manually updated in concert (I'm not currently using it).

It's possible it already has these committees. Can you check? If so, we should be OK to merge this.

I only spot checked one, but unfortunately it looks like it is missing.

While the last commit was made in March, it doesn't look like it has been very actively maintained. 🤔 That said, perhaps it is maintained in the right cadence relative to the pace of change -- I'm not sure.
https://github.com/unitedstates/congress-legislators/commits/main/committees-historical.yaml

In any event, here's an example of the HSGO 25 Information Technology subcommittee I spot checked ... https://github.com/unitedstates/congress-legislators/pull/890/files#diff-fac9b9f1518db85a76e9073b70b23a5511f7dfe0b38c92e16d212689d0aefc75L299

For convenience, I've excerpted a sample of the relevant committees-historical.yaml as one example that might need attention.

HSGO committees-historical.yaml Excerpt https://github.com/unitedstates/congress-legislators/blob/main/committees-historical.yaml#L2528 ``` - type: house name: House Committee on Government Operations thomas_id: HSGO congresses: - 93 - 94 - 95 - 96 - 97 - 98 - 99 - 100 - 101 - 102 - 103 - 104 - 105 - 106 - 107 - 108 - 109 - 110 - 111 - 112 - 113 - 114 - 115 names: 93: Government Operations 94: Government Operations 95: Government Operations 96: Government Operations 97: Government Operations 98: Government Operations 99: Government Operations 100: Government Operations 101: Government Operations 102: Government Operations 103: Government Operations 104: Government Reform and Oversight 105: Government Reform and Oversight 106: Government Reform 107: Government Reform 108: Government Reform 109: Government Reform 110: Oversight and Government Reform 111: Oversight and Government Reform 112: Oversight and Government Reform 113: Oversight and Government Reform 114: Oversight and Government Reform 115: Oversight and Government Reform subcommittees: - name: Commerce, Consumer, and Monetary Affairs thomas_id: '05' congresses: - 97 - 100 names: 97: Commerce, Consumer, and Monetary Affairs 100: Commerce, Consumer, and Monetary Affairs - name: Government Activities and Transportation thomas_id: '03' congresses: - 97 - 98 - 99 - 100 - 101 - 102 names: 97: Government Activities and Transportation 98: Government Activities and Transportation 99: Government Activities and Transportation 100: Government Activities and Transportation 101: Government Activities and Transportation 102: Government Activities and Transportation - name: Government Information and Individual Rights thomas_id: '02' congresses: - 97 - 98 - 99 - 100 - 101 - 102 - 103 names: 97: Government Information and Individual Rights 98: Government Information, Justice, and Agriculture 99: Government Information, Justice, and Agriculture 100: Government Information, Justice, and Agriculture 101: Government Information, Justice, and Agriculture 102: Government Information, Justice, and Agriculture 103: Information, Justice, Transportation, and Agriculture - name: Intergovernmental Relations and Human Resources thomas_id: '04' congresses: - 97 - 98 - 99 - 100 - 101 - 102 - 103 - 104 - 105 names: 97: Intergovernmental Relations and Human Resources 98: Intergovernmental Relations and Human Resources 99: Intergovernmental Relations and Human Resources 100: Human Resources and Intergovernmental Relations 101: Human Resources and Intergovernmental Relations 102: Human Resources and Intergovernmental Relations 103: Human Resources and Intergovernmental Relations 104: Human Resources and Intergovernmental Relations 105: Human Resources - name: Legislation and National Security thomas_id: '06' congresses: - 97 - 98 - 99 - 100 - 101 - 102 - 103 - 104 - 105 - 107 names: 97: Legislation and National Security 98: Legislation and National Security 99: Legislation and National Security 100: Legislation and National Security 101: Legislation and National Security 102: Legislation and National Security 103: Legislation and National Security 104: National Security, International Affairs and Criminal Justice 105: National Security, International Affairs and Criminal Justice 107: National Security, Veterans Affairs and International Relations - name: Manpower and Housing thomas_id: '07' congresses: - 97 names: 97: Manpower and Housing ```

Accurately attributing these to which congresses each applies to could involve lots more work.
Updating them is probably more than I can bite off at the moment.
Hopefully someone else can chip in and fill in the gaps tho 🤞

Alternately, I guess a separate issue could be filed to backfill committees-historical.yaml in isolation?
Pros/cons, with that I guess tho.

JoshData commented 1 year ago

Thanks for checking. No need to hold this up for the other file.