search

unitedstates / congress-legislators

Members of the United States Congress, 1789-Present, in YAML/JSON/CSV, as well as committees, presidents, and vice presidents.
Creative Commons Zero v1.0 Universal
2.03k stars 502 forks source link

Added Tom Suozzi NY district 3 #915

Closed admarwick closed 5 months ago

admarwick commented 5 months ago

I found and -- I think -- fixed several syntax errors in the file being updated by PR #915 that were caught by the yaml linter but the now the test report I'm seeing from test/validate.py makes no sense to me and I need help. Sorry.

JoshData commented 5 months ago

Yeah the test output is very noisy. The errors new to this PR are:

: bioguide S001201 is duplicated: S001201 S001201
: fec H6NY03247 is duplicated: S001201 S001201
: govtrack 412717 is duplicated: S001201 S001201
: opensecrets N00038742 is duplicated: S001201 S001201
: wikipedia Thomas Suozzi is duplicated: S001201 S001201
: wikidata Q7794276 is duplicated: S001201 S001201
: ballotpedia Tom Suozzi is duplicated: S001201 S001201
: votesmart 92111 is duplicated: S001201 S001201

These are duplicates because Suozzi has to be deleted from the historical file so that he only has one entry between the two files, and his old terms have to be combined with the new terms in the "current" file.

I did this and pushed to your branch. The tests now pass so I'll merge.

Thanks!