search

unitedstates / congressional-record

A parser for the Congressional Record.
Other
128 stars 40 forks source link

Prepare for PyPI, add console script, updates to CLI date parsing #11

Closed jcarbaugh closed 10 years ago

jcarbaugh commented 10 years ago

Includes a number of changes for packaging and release on PyPI:

Extracted some date util methods from the CLI. They'll need to be moved out to somewhere reusable later, but this is a start. Also updated the parsing of the command line date arguments so more complex date ranges can be passed:

parsecr 2014-01-28:2014-01-30 2014-02-05 2014-02-12:2014-02-14

Fixed a bug (that I may have introduced) in default output directory that caused dates to be nested inside each other on the filesystem.

LindsayYoung commented 10 years ago

Awesome. Thank you Jeremy!

Lindsay Young Sunlight Foundation http://www.sunlightfoundation.com/

On Fri, Feb 21, 2014 at 12:02 PM, Jeremy Carbaugh notifications@github.comwrote:

Includes a number of changes for packaging and release on PyPI:

  • create congressionalrecord module and move existing content inside
  • update setup.py to remove unnecessary requirements
  • add console_scripts so parsecr can be run from anywhere
  • add @LindsayYoung https://github.com/LindsayYoung to setup.py author info

Extracted some date util methods from the CLI. They'll need to be moved out to somewhere reusable later, but this is a start. Also updated the parsing of the command line date arguments so more complex date ranges can be passed:

parsecr 2014-01-28:2014-01-30 2014-02-05 2014-02-12:2014-02-14

Fixed a bug (that I may have introduced) in default output directory that

caused dates to be nested inside each other on the filesystem.

You can merge this Pull Request by running

git pull https://github.com/jcarbaugh/congressional-record master

Or view, comment on, or merge it at:

https://github.com/unitedstates/congressional-record/pull/11 Commit Summary

  • Create congressionalrecord package, update setup.py, and create cli module.
  • Move package version number.
  • Update required Python version number.
  • Update LICENSE filename in MANIFEST.in
  • Use getcwd() for default output directory instead of file
  • Require outdir arg in simple_scrape.find_fdsys
  • Fix output path bug and extract some date util methods, which should be moved out into something else later. Also, update parsing of date args so you can do more complicated stuff like "2014-01-28:2014-01-30 2014-02-05 2014-02-12:2014-02-15".

File Changes

  • M MANIFEST.inhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-0(2)
  • M README.mdhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-1(14)
  • A congressionalrecord/init.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-2(1)
  • R congressionalrecord/cli.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-3(85)
  • R congressionalrecord/fdsys/init.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-4(0)
  • R congressionalrecord/fdsys/cr_parser.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-5(20)
  • R congressionalrecord/fdsys/errors.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-6(0)
  • R congressionalrecord/fdsys/simple_scrape.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-7(16)
  • R congressionalrecord/lib/init.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-8(0)
  • R congressionalrecord/lib/logging.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-9(0)
  • R congressionalrecord/lib/regex.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-10(0)
  • R congressionalrecord/lib/xml_annotator.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-11(2)
  • M requirements.txthttps://github.com/unitedstates/congressional-record/pull/11/files#diff-12(2)
  • M setup.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-13(33)
  • M test/runhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-14(3)
  • M test/test_parser.pyhttps://github.com/unitedstates/congressional-record/pull/11/files#diff-15(36)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/unitedstates/congressional-record/pull/11 .

konklone commented 10 years ago

Wow, damn, @jcarbaugh. :) Looks all good to me. Though, I think @drinks may have some similar work happening...?

jcarbaugh commented 10 years ago

@konklone, I coordinated with @drinks this morning. I didn't get to all the things he wanted to accomplish, but this should cross a few of them off his list.

jcarbaugh commented 10 years ago

:+1: right you are, @drinks