search

unitedstates / congressional-record

A parser for the Congressional Record.
Other
128 stars 40 forks source link

Officially Support Python 3 #35

Closed AlJohri closed 6 years ago

AlJohri commented 6 years ago

hi all, just opening this issue here to remind myself to fix some of the smaller unicode bugs I noticed while running the tests on python 3. @napsternxg have you had a chance to try this out on python 3 yet? any bugs?

AlJohri commented 6 years ago

wait, tests are already passing? https://travis-ci.org/unitedstates/congressional-record huh well, that works for me!

nclarkjudd commented 6 years ago

Could you be specific about what unicode issues persist? It is possible that the test suite simply isn't testing for them.

On the other hand, there really shouldn't be much trouble to cause. When I refactored this, I set it up to pass each page through BeautifulSoup. So any issues would happen in the portions of the code that generate output.

The json parser gives you flat files full of nuggets of json, so the potential for error is small there. The only place where I would suspect one might encounter issues after having software manage the 2-to-3 migration is in writing to csv, because I frankly forget if that is good code or something I cobbled together quickly. There aren't any tests to make sure, for e.g., that names are not mangled. Perhaps there should be ...

AlJohri commented 6 years ago

hi @nclarkjudd, I'm relatively sure I was thinking of openelections when I mentioned that. I was working on converting both this project and openelections-core to python3 and misremembered which one had the unicode issues in the test suite. this project should most likely be good to go! :)